fix(worktree): scope catalog and simplify management - #1844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1841 based on post-merge review and hands-on validation:
Behavior
Manual deletion removes the checkout and its workspace registration while preserving associated conversation metadata and history. Dirty or unpublished work still requires the stronger destructive confirmation.
Clicking an active associated conversation opens it through the existing Agent companion session flow. If its workspace session metadata is not currently loaded, the settings page refreshes that workspace and retries. Clicking an archived conversation first offers to restore it, then opens it.
Initial loading uses a compact skeleton. Later refreshes retain the existing list with a small progress indicator instead of replacing the list and collapsing the scroll area. Successful deletion removes the row optimistically after a short exit transition, preserves the scroll anchor, and coalesces the backend change event with the explicit refresh.
The catalog resolves
app.worktrees.rootPathand includes only descendant worktrees. The per-project worktree API used by session flows remains unchanged, so this does not alter Agent worktree creation or binding behavior added in #1841.Verification
cargo check --workspacecargo test -p bitfun-core service::worktree::tests::(18 passed)pnpm run type-check:webpnpm run lint:webpnpm --dir src/web-ui run test:run src/infrastructure/config/components/WorktreesConfig.test.tsx src/infrastructure/config/components/common/ConfigPageLayout.test.tsx(11 passed)pnpm run i18n:audit(0 warnings)node scripts/check-core-boundaries.mjspnpm run fmt:rsReviewer Notes
prefers-reduced-motion.